-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to report the document layout in Microsoft Word #17324
base: master
Are you sure you want to change the base?
Conversation
See test results for failed build of commit c51766ccdb |
I really don't think this should be in the title bar (it isn't visually, right?). Perhaps it could be assigned to a separate script? |
Hi Noelia. Thanks for addressing this issue. It will be very useful. This approach with the status bar is not the best design choice IMO. Indeed, the view ribbon allow you to select outline or draft mode but there are no corresponding buttons, at least by default, in the status bar. Also, are we sure that the status bar cannot contain any other pressed button? As suggested in #15088 (comment), I'd rather opt for the Word Object Model approach. Using the macro recorder and playing with the buttons in the view ribbon, you can find the relevant objects/properties/methods; then you can complete your information by googling the corresponding MSDN page (e.g. "VBA word view"). Also, rather than duplicating the NVDA+T script, I'd keep one single script. As for the processing done to read the status bar text (see
To be complete, the drawback of having one single script is that you cannot use a separate description in Word. |
Re @codeofdusk feedback:
|
What about including it in the |
Yes, that seems an interesting option. It would be reported when the document gets focused or when calling |
For me, adding this to the document name is a good option. |
Exploring Microsoft Word, pragmatically, I think that including this in the title may be more useful. For example, if we want to change the layout from the ribbon, we may press NVDA+tab to remember the focused button, and we can have the current layout in the title. |
I'll mark this as ready for review, and feedback is welcome. |
Link to issue number:
Fixes issue #15088
Summary of the issue:
Knowing the document layout in Microsoft Word may be important, for example, to figure out why a table is not read properly when navigating with NVDA, and in other situations.
Description of user facing changes
When using the report title command in Microsoft Word, if the document layout can be determined, it Will be added to the title.
When Microsoft Word is active, in the input gestures dialog, the description of this command will be presented indicating that it works in Word, in contrast to the report title command of global commands.
Description of development approach
In the WinWord app module, a script has been created, using
api.getStatusBar()
to search for the status bar. If it can be found, and one of the bar status children has the PRESSED state, its name Will be added to the title, assuming that it correspond to the document layout.Testing strategy:
Tested manually, in Word documents, with the ribbon active and inactive, and with a dialog opened to check that the title without the document layout is reported when the status bar is not found.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary